Restore IO_REG_TYPE definition for AVR#110
Open
per1234 wants to merge 1 commit intoPaulStoffregen:masterfrom
Open
Restore IO_REG_TYPE definition for AVR#110per1234 wants to merge 1 commit intoPaulStoffregen:masterfrom
IO_REG_TYPE definition for AVR#110per1234 wants to merge 1 commit intoPaulStoffregen:masterfrom
Conversation
The definition of the `IO_REG_TYPE` macro when compiling for an AVR target was accidentally removed by the previous
commit. This resulted in the library failing to compile for those targets:
```
Encoder.h:66:11: error: 'IO_REG_TYPE' does not name a type
volatile IO_REG_TYPE * pin1_register;
^~~~~~~~~~~
```
The macro definition is hereby restored.
|
@PaulStoffregen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The definition of the
IO_REG_TYPEmacro when compiling for an AVR target was accidentally removed by #102:063b390#diff-334c08ee1cc76e8313e155ce41d8d06f284a691a9d492996f98c5e5731ac0f60L6
This resulted in the library failing to compile for those targets:
The macro definition is hereby restored.