Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix small issue in event display notebook
There is a small bit of extra silicon at the edge of the detector - it's slightly larger than what the number of pixels would suggest. From the number of pixels the detector is 12788 * 20.8 = 265990.4 um wide, but we assume a total detector width of 266000 um, so 10 um larger and we can get a total of 12789 colIDs.
Hits here do not actually count as pixel hits and thier indices will overstep the bound of the geometry array which keeps track of the x/y positions
So here we create a mask which removes these edge cases, otherwise the code will crash when indexing
geom["pixel_X/Ypos"](oversteps bounds of array)Thanks @tobias-boeckh for spotting this!