This repository was archived by the owner on Apr 10, 2025. It is now read-only.
Fix segmenter "flat calculation" trigger criteria#73
Open
fabienlombard wants to merge 7 commits intomainfrom
Open
Fix segmenter "flat calculation" trigger criteria#73fabienlombard wants to merge 7 commits intomainfrom
fabienlombard wants to merge 7 commits intomainfrom
Conversation
trial to correct the segmenter
ethanjli
changed the title
This is an optimisation attempt to calculate the flat on only 5 images and to do it every 15 images only (not always). This way the calculation should be way lighter
Member
|
@fabienlombard says that all commits starting with b60c2cb are currently non-functional. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a Slack DM conversation about potential bugs in the segmenter's logic for when it re-triggers the "flat calculation" step.