feat(ci/cd): Add releaser integration#99
Conversation
.github/workflows/release.yml
Outdated
| permissions: | ||
| contents: write | ||
| actions: write | ||
| id-token: write |
There was a problem hiding this comment.
Hmm, you don't need id-token for PHP. Might need to mention on the documentation that this is only needed when using OIDC deployment - which I don't think makes sense for PHP
.github/workflows/release.yml
Outdated
| run: | | ||
| current_version="${{ steps.bump-version.outputs.current_version }}" | ||
| new_version="${{ steps.bump-version.outputs.new_version }}" | ||
| echo -e "## $new_version\n\n* [Full Changelog](https://github.com/PostHog/posthog-php/compare/v${current_version}...v${new_version})\n\n$(cat CHANGELOG.md)" > CHANGELOG.md |
There was a problem hiding this comment.
looks like it is currently called History.md
do we need to add a CHANGELOG.md with the History.md contents
point a link to CHANGELOG.md in the History.md
??
There was a problem hiding this comment.
also nit that it'd be good to have the day's date there for the future traveller
There was a problem hiding this comment.
Good idea! Added it to the generation flow and will backport it to the posthog-go SDK as well 🙌
pauldambra
left a comment
pauldambra
left a comment
There was a problem hiding this comment.
i've been removed from these changes but this is easy to change if needed so 🚢 🚢 🚢 🚢 🚢
(NB i think there needs to be some CHANGELOG creation)
rafaeelaudibert
left a comment
rafaeelaudibert
left a comment
There was a problem hiding this comment.
It's interesting how this is just pushing a tag rather than publishing somewhere, but lgtm! Left a minor nit but don't have to fix it here
README.md
Outdated
|
|
||
| 1. **Create your PR** with the changes you want to release | ||
| 2. **Add the `release` label** to the PR | ||
| 3. **Add a version bump label** that should be either `patch`, `minor` or `major` |
There was a problem hiding this comment.
This is wrong, your action is expecting bump-patch, bump-minor or bump-major. Can you make them match?
|
Addressed both of your comments! I copied this file from the Should now be fixed!
|
rafaeelaudibert
left a comment
rafaeelaudibert
left a comment
There was a problem hiding this comment.
LGTM! Check the SDK Doctor code on posthog/posthog to make sure we didn't depend on History.md. IIRC we're using releases so it should be fine, but double-check it please!
|
Ah good shout! TIL that there is a connection between the 2! Here we go! PostHog/posthog#44560 |
3 participants
Adds support for the
Releaser (posthog-php)integration as documented over here: https://posthog.com/handbook/engineering/sdks/releases.