Fix OpenAI input image sanitization#384
Merged
ablaszkiewicz merged 2 commits intoPostHog:masterfrom Feb 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Additional Comments (1)
-
posthog/ai/sanitization.py, line 99-102 (link)style: inconsistent type checking -
sanitize_openai_imagechecksisinstance(item.get("image_url"), str)but this function only checks"image_url" in item
2 files reviewed, 1 comment
Contributor
Author
|
@ablaszkiewicz Sorry for tagging you but any chance to review this? |
Contributor
|
lgtm ✅ Python pipeline is currently broken. We are fixing it |
Contributor
Author
|
@ablaszkiewicz hey , any update on this |
Contributor
|
@vikas5914 can you please recreate this PR as a new one? You can tag me there |
ablaszkiewicz
approved these changes
Feb 6, 2026
Contributor
|
@vikas5914 nevermind. It went through |
Contributor
|
@vikas5914 Ooops there was no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend
sanitize_openai_imageto redact base64 data when OpenAI’s Responses API sends input_image items where image_url is a string (as documented here).Restore the regression test for that payload format so we cover both dict-style image_url objects and string URLs.
The previous check only handled { "type": "image_url", "image_url": { "url": ... } }. But OpenAI also allows:
Example from the official docs:
Without this fix, base64 strings in that shape weren’t redacted.