feat: Deprecate get_feature_flag_payload in favor of get_feature_flag…#394
Open
mohamedzair wants to merge 3 commits intoPostHog:masterfrom
Open
feat: Deprecate get_feature_flag_payload in favor of get_feature_flag…#394mohamedzair wants to merge 3 commits intoPostHog:masterfrom
mohamedzair wants to merge 3 commits intoPostHog:masterfrom
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Additional Comments (1)
-
posthog/client.py, line 1831-1836 (link)logic: Missing test coverage for the deprecation warning. Add a test using
assertWarnsto verify the warning is raised whenget_feature_flag_payloadis called.
1 file reviewed, 1 comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a
DeprecationWarningtoget_feature_flag_payload.Reasoning:
As discussed in issue PostHog/posthog#43520, this method retrieves data without emitting a usage event, confusing users.
Fixes: PostHog/posthog#43520