fix(llma): small fixes for prompt management#420
Merged
Radu-Raicea merged 3 commits intomasterfrom Feb 4, 2026
Merged
Conversation
Contributor
posthog-python Compliance ReportDate: 2026-02-03 18:42:04 UTC
|
| Test | Status | Duration |
|---|---|---|
| Format Validation.Event Has Required Fields | ✅ | 518ms |
| Format Validation.Event Has Uuid | ✅ | 1508ms |
| Format Validation.Event Has Lib Properties | ✅ | 1507ms |
| Format Validation.Distinct Id Is String | ✅ | 1506ms |
| Format Validation.Token Is Present | ✅ | 1507ms |
| Format Validation.Custom Properties Preserved | ✅ | 1507ms |
| Format Validation.Event Has Timestamp | ✅ | 1507ms |
| Retry Behavior.Retries On 503 | ✅ | 6906ms |
| Retry Behavior.Does Not Retry On 400 | ✅ | 3504ms |
| Retry Behavior.Does Not Retry On 401 | ✅ | 3508ms |
| Retry Behavior.Respects Retry After Header | ❌ | 7387ms |
| Retry Behavior.Implements Backoff | ✅ | 20697ms |
| Retry Behavior.Retries On 500 | ✅ | 6666ms |
| Retry Behavior.Retries On 502 | ✅ | 6987ms |
| Retry Behavior.Retries On 504 | ✅ | 6724ms |
| Retry Behavior.Max Retries Respected | ✅ | 20809ms |
| Deduplication.Generates Unique Uuids | ✅ | 1496ms |
| Deduplication.Preserves Uuid On Retry | ✅ | 7291ms |
| Deduplication.Preserves Uuid And Timestamp On Retry | ✅ | 14188ms |
| Deduplication.Preserves Uuid And Timestamp On Batch Retry | ✅ | 6863ms |
| Deduplication.No Duplicate Events In Batch | ✅ | 1504ms |
| Deduplication.Different Events Have Different Uuids | ✅ | 1506ms |
| Compression.Sends Gzip When Enabled | ✅ | 1508ms |
| Batch Format.Uses Proper Batch Structure | ✅ | 1506ms |
| Batch Format.Flush With No Events Sends Nothing | ✅ | 1005ms |
| Batch Format.Multiple Events Batched Together | ✅ | 1505ms |
| Error Handling.Does Not Retry On 403 | ✅ | 3509ms |
| Error Handling.Does Not Retry On 413 | ✅ | 3506ms |
| Error Handling.Retries On 408 | ❌ | 6510ms |
Failures
retry_behavior.respects_retry_after_header
Retry delay too short: 880ms < 2500ms
error_handling.retries_on_408
Expected at least 2 requests, got 1
Contributor
Additional Comments (1)
Prompt To Fix With AIThis is a comment left during a code review.
Path: posthog/test/ai/test_prompts.py
Line: 373:373
Comment:
URL path needs updating from /api/projects/@current/ to /api/environments/@current/
```suggestion
"https://eu.i.posthog.com/api/environments/@current/llm_prompts/name/test-prompt/",
```
How can I resolve this? If you propose a fix, please make it concise. |
richardsolomou
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fixes for the prompt management implementation.