-
Notifications
You must be signed in to change notification settings - Fork 748
chore: flutter manual start and stop recording #14487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
approved! but the changelog / releases do not make it clear why 5.12.0+ is required, maybe a quick note about that would be good? |
|
|
||
| Setting `config.sessionReplay = true` in your PostHog configuration will start session recordings on SDK setup. | ||
|
|
||
| ### Manually control session recordings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JS SDK documents this on this page https://posthog.com/docs/session-replay/how-to-control-which-sessions-you-record
Android and iOS documents under the privacy page https://posthog.com/docs/session-replay/privacy?tab=Android
i think we should move the android and ios docs to the "how-to-control-which-sessions-you-record" page and add code snippets per platform similar to the privacy page, with tabs.
and move this to that page as well
right now we're gonna have the same content in 3 different pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved manual session recording docs inside "how to control which session you record" page as suggested above.
I left a small note linking to this page in privacy pages. Can you please have another look once preview is deployed?
contents/docs/session-replay/_snippets/android-manual-replay-control.mdx
Show resolved
Hide resolved
| ### Manually control session recordings | ||
|
|
||
| You can programmatically start and stop session recordings. See [how to control which sessions you record](/docs/session-replay/how-to-control-which-sessions-you-record#programmatically-start-and-stop-recordings) for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be extracted to its own file since its the same for all platforms, just a nit tho
| // Some time later when the sheet is dismissed, resume recording | ||
| PostHog.startSessionReplay() | ||
| ``` | ||
| For third-party components (like payment forms or authentication screens) that can't be masked, you can manually stop and start session recordings. See [how to control which sessions you record](/docs/session-replay/how-to-control-which-sessions-you-record#programmatically-start-and-stop-recordings) for details. No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont think we have this section for the web-privacy, worth adding
marandaneto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few suggestions otherwise LGTM
Changes
see: PostHog/posthog-flutter#256
Please describe.
Add screenshots or screen recordings for visual / UI-focused changes.
Checklist
vercel.jsonArticle checklist