Add upgradeable ERC721 SeaDrop proxy tests #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Add upgradeable ERC721 SeaDrop proxy tests
Motivation
The upgradeable package relied on Hardhat/OZ upgrades but shipped without any tests, so the proxy-safe ERC721 implementation had zero coverage. Without parity checks we cannot detect regressions in owner-only forwarding, mint gating, or storage layout across upgrades.
Solution
Added a lightweight SeaDrop mock plus a V2 token stub, then wrote a dedicated Hardhat test suite under
src-upgradeable/test/that deploys the proxy, verifies privileged configuration/minting mirrors the non-upgradeable contract, and asserts state survives upgrades. Wired the upgradeable Hardhat config/tsconfig to compile these specs and documented how to runyarn test:upgradeable. (Tests currently fail here because Node/yarn aren’t installed in this environment.)