Moves dependencies and submodules behind Features#55
Moves dependencies and submodules behind Features#55Hate9 wants to merge 3 commits intoQuartzLibrary:mainfrom
Conversation
|
Hi, could you elaborate on what the goal is? People usually want to avoid deps for one of three reasons:
In general I am not very strict with deps as long as my iteration cycle is not impacted (which it normally isn't if incremental compilation works well enough). Some notes on the PR:
Features are also kind of annoying to work with, and I wouldn't trust them to not be broken without CI checking each combination, so, if we want this, let's keep it to a minimum and make sure it's tested. Just adding (As an aside, I will likely be slow to respond for the foreseeable future.) |
|
Hmm... Good point that the number of Features might be excessive. I initially made this because I wanted to be able to have the API interaction and EPUB/HTML generation code separate, since it would be useful to be able to import this crate as a library for just the API interaction. I can simplify things to make it actually just do that, instead of adding too many granular Feature options. Using minimal features on |
|
There, that should be better. |
Glowpub is potentially quite useful as a library, but it has a lot of dependencies, which makes it a very large import if you only need a small subset of its functionality.
This PR moves everything behind Feature flags, so you can choose to import only the utils, or only the auth code, or even just the base types if you need those for whatever reason.
The
genflag could probably be split up into a few sub-features for independent submodules, but otherwise I think this PR works well.