Skip to content

Fix 348 #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
supersaiyansubtlety wants to merge 2 commits into
base: develop/2.8
Choose a base branch
from
Open

Fix 348 #352

supersaiyansubtlety wants to merge 2 commits into from

Conversation

@supersaiyansubtlety
Copy link
Member

@supersaiyansubtlety supersaiyansubtlety commented Dec 17, 2025

Fixes #348

#306 made EntryRemapper use the combined JarIndex instead of the main JarIndex

That allowed its MappingValidator to detect conflicts with inherited lib methods, but resulted in its EntryResolver resolving roots in lib classes.

This makes EntryRemapper use the combined index for its MappingValidator and the main index for its EntryResolver.

This required breaking changes to EntryRemapper's factory methods.

@supersaiyansubtlety supersaiyansubtlety self-assigned this Dec 17, 2025
@supersaiyansubtlety supersaiyansubtlety added bug Something isn't working backend affects the enigma backend labels Dec 17, 2025
@supersaiyansubtlety supersaiyansubtlety linked an issue Dec 17, 2025 that may be closed by this pull request
Naming a lib method param creates a lib mapping #348
Open
@ix0rai ix0rai self-requested a review January 16, 2026 17:04
ix0rai
ix0rai approved these changes Jan 30, 2026
View reviewed changes
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ix0rai ix0rai ix0rai approved these changes

Assignees

@supersaiyansubtlety supersaiyansubtlety

Labels

backend affects the enigma backend bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Naming a lib method param creates a lib mapping

2 participants

@supersaiyansubtlety @ix0rai