[AIROCMLIR-62] Add verification support for attention#2235
Open
mirza-halilcevic wants to merge 2 commits intodevelopfrom
Open
[AIROCMLIR-62] Add verification support for attention#2235mirza-halilcevic wants to merge 2 commits intodevelopfrom
mirza-halilcevic wants to merge 2 commits intodevelopfrom
Conversation
mirza-halilcevic
requested review from
dhernandez0,
justinrosner,
pabloantoniom and
umangyadav
umangyadav
reviewed
Feb 9, 2026
Comment on lines
+4831
to
+4836
| if (!((heuristicValidation || hasAccel) && | ||
| genParams.types[0].isInteger(8))) { | ||
| SmallVector<Type, 5> newTypes; | ||
| for (Type t : genParams.types) | ||
| newTypes.push_back(isa<IntegerType>(t) ? t : b.getF32Type()); | ||
| newParams.types = newTypes; |
Member
There was a problem hiding this comment.
So it will use FP32 for the attention ? It may not work on Navis
umangyadav
reviewed
Feb 9, 2026
Comment on lines
+4828
to
+4829
| if (heuristicValidation || hasAccel) | ||
| newParams.perfConfig = ""; |
Member
There was a problem hiding this comment.
This assumes heuristic perf config verifies correctly. Is it guranteed ?
dhernandez0
reviewed
Feb 9, 2026
| } else if (genParams.operation == rock::KernelType::Attention) { | ||
| // attention GPU validation | ||
| // Attention has no non-accel path, so keep accel features and just | ||
| // use the heuristic perf config as the reference. |
Contributor
There was a problem hiding this comment.
are we sure we even want to do this? for gemms at least it's a partially different code path. Here, if there are bugs common to different perfConfigs, it will still pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Verifier for attention was missing causing gpu verification to fail.
Technical Details
Implement verification code path for attention kernels.
Test Plan
Test Result
Submission Checklist