1069-add-immediate-onboarding #640
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
…mimic current behaviour
danhalson
force-pushed
the
1069-add-immediate-onboarding
branch
from
2c1ff13 to
12f5e0a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request introduces immediate school onboarding functionality behind a feature flag ENABLE_IMMEDIATE_SCHOOL_ONBOARDING. The main changes separate the onboarding logic (role creation and Profile API registration) from the verification process, and automatically generate school codes at creation time rather than at verification time. Additionally, administrative_area and postal_code are made required fields to match frontend validation.
Changes:
- Added
SchoolOnboardingServiceto handle role creation and Profile API registration - Modified
SchoolVerificationServiceto conditionally skip onboarding when the feature flag is enabled - Updated
Schoolmodel to generate codes automatically viaafter_commitcallback when immediate onboarding is enabled - Updated
School::Createoperation to call onboarding service when feature flag is enabled - Made
administrative_areaandpostal_coderequired fields on theSchoolmodel
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
lib/feature_flags.rb |
New module defining the immediate_school_onboarding? method to check the feature flag |
app/services/school_onboarding_service.rb |
New service extracting onboarding logic (role creation, Profile API registration) |
app/services/school_verification_service.rb |
Modified to conditionally delegate to onboarding service based on feature flag |
app/models/school.rb |
Added validations for new required fields, after_commit callback for code generation, refactored verify! and generate_code! methods |
lib/concepts/school/operations/create.rb |
Added token parameter and onboarding service call within transaction |
app/controllers/api/schools_controller.rb |
Updated to pass token parameter to School::Create |
app/jobs/school_import_job.rb |
Updated to pass token parameter to School::Create |
spec/services/school_verification_service_spec.rb |
Added test coverage for both feature flag states |
spec/services/school_onboarding_service_spec.rb |
New test file for onboarding service |
spec/models/school_spec.rb |
Updated tests for new validations and code generation behavior |
spec/lib/feature_flags_spec.rb |
New test file for feature flag module |
spec/jobs/school_import_job_spec.rb |
Updated test data to include new required fields |
spec/features/school/showing_a_school_spec.rb |
Simplified test for forbidden access scenario |
spec/features/school/creating_a_school_spec.rb |
Updated test data to include new required fields |
spec/factories/school.rb |
Updated factory to generate new required fields using Faker |
spec/concepts/school/create_spec.rb |
Updated all calls to include token parameter and adjusted error count expectation |
lib/tasks/seeds_helper.rb |
Added generation of new required fields in seed helper |
.env.example |
Documented new feature flag environment variable |
…if the code fails This is really an edge case, but because of that in the unlikely case it happens we're better off erroring and fixing it. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was the result of a merge conflict, the original behaviour needs to be preserved Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…not called int he school concept depending on the feature flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
What's changed?
administrative_areaandpostal_codeto required fields, to match the frontendENABLE_IMMEDIATE_SCHOOL_ONBOARDINGSteps to perform after deploying to production
N/A