Let Commands wait for state to execute or expire#10
Open
timshadel wants to merge 2 commits intoReactorSwift:masterfrom
Open
Let Commands wait for state to execute or expire#10timshadel wants to merge 2 commits intoReactorSwift:masterfrom
timshadel wants to merge 2 commits intoReactorSwift:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent is to make it easy to issue several back-to-back commands that implicitly depend on each other before they can run.
GetLocationandGetWeatherare an example. You need to know the location before you can request the weather. By issuing them both at the same time, your location command can see that the existing location is recent enough, and choose to do nothing in it'sexecute(state:, core:)function, and the weather command will still run properly since it will find location in the proper place in state.canExecute(state:)will default to expiring in 10 seconds.core, but if that happens your app is lifeless, so in practice this shouldn't be a problem...I think.