Open
Conversation
sumitd94
suggested changes
Mar 11, 2021
Contributor
sumitd94
left a comment
sumitd94
left a comment
There was a problem hiding this comment.
One change requested, please check.
pages/notification.js
Outdated
Comment on lines
11
to
64
| <li> | ||
| <div className="notificationArea"> | ||
| <h4>Rohit has requested RDS 200 from you</h4> | ||
| <div className="buttons"> | ||
| <button className="approve">Approve</button> | ||
| <button className="discard">Discard</button> | ||
| </div> | ||
| </div> | ||
| </li> | ||
| <li> | ||
| <div className="notificationArea"> | ||
| <h4>Rohit has requested RDS 200 from you</h4> | ||
| <div className="buttons"> | ||
| <button className="approve">Approve</button> | ||
| <button className="discard">Discard</button> | ||
| </div> | ||
| </div> | ||
| </li> | ||
| <li> | ||
| <div className="notificationArea"> | ||
| <h4>Rohit has requested RDS 200 from you</h4> | ||
| <div className="buttons"> | ||
| <button className="approve">Approve</button> | ||
| <button className="discard">Discard</button> | ||
| </div> | ||
| </div> | ||
| </li> | ||
| <li> | ||
| <div className="notificationArea"> | ||
| <h4>Rohit has requested RDS 200 from you</h4> | ||
| <div className="buttons"> | ||
| <button className="approve">Approve</button> | ||
| <button className="discard">Discard</button> | ||
| </div> | ||
| </div> | ||
| </li> | ||
| <li> | ||
| <div className="notificationArea"> | ||
| <h4>Rohit has requested RDS 200 from you</h4> | ||
| <div className="buttons"> | ||
| <button className="approve">Approve</button> | ||
| <button className="discard">Discard</button> | ||
| </div> | ||
| </div> | ||
| </li> | ||
| <li> | ||
| <div className="notificationArea"> | ||
| <h4>Rohit has requested RDS 200 from you</h4> | ||
| <div className="buttons"> | ||
| <button className="approve">Approve</button> | ||
| <button className="discard">Discard</button> | ||
| </div> | ||
| </div> | ||
| </li> |
Contributor
There was a problem hiding this comment.
Can we please refactor this? li has a similar pattern throughout. Maybe create a new function that returns this li and call that function 4-5 times, or create a component and call that component 4-5 times.
That will make this code much more clean and readable.
Contributor
Author
There was a problem hiding this comment.
Ok thnks. I will make the changes.
Contributor
Author
There was a problem hiding this comment.
@sumitd94 Changes has been made. Please check.
ankushdharkar
had a problem deploying
to
crypto-pipel-rohitkuwar-k1moxl
sumitd94
suggested changes
Mar 12, 2021
Contributor
sumitd94
left a comment
sumitd94
left a comment
There was a problem hiding this comment.
One small change requested please.
pages/notification.js
Outdated
| { | ||
| data.map((item) => { | ||
| return( | ||
| <li> |
Contributor
Author
There was a problem hiding this comment.
Done. Please check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Kratika0907 Please review the PR.
Notification link in the dropdown.
notification page in desktop view.
notification page in mobile view.
