feat: added stepper component and tests#408
Open
bajajcodes wants to merge 7 commits intoRealDevSquad:developfrom
Open
feat: added stepper component and tests#408bajajcodes wants to merge 7 commits intoRealDevSquad:developfrom
bajajcodes wants to merge 7 commits intoRealDevSquad:developfrom
Conversation
✅ Deploy Preview for staging-my ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
rohan09-raj
changed the title
rohan09-raj
changed the title
rohan09-raj
suggested changes
May 28, 2023
Contributor
rohan09-raj
left a comment
rohan09-raj
left a comment
There was a problem hiding this comment.
@shmbajaj Requesting some changes and added some comments, please take a pull from your branch (I have resolved a conflict) before doing any further changes
Comment on lines
+9
to
+12
| <svg xmlns='http://www.w3.org/2000/svg' width='16' height='16' fill='#1d1283' viewBox='0 0 256 256'> | ||
| <path d='M232,128A104,104,0,1,1,128,24,104.13,104.13,0,0,1,232,128Z'> | ||
| </path> | ||
| </svg> |
Contributor
There was a problem hiding this comment.
Can we please use svg in img tag?
| <article data-test-stepper class='stepper'> | ||
| <div class='stepper-progress--container'> | ||
| <div class='progress'></div> | ||
| {{#each this.numberOfSteps as |_ index|}} |
Contributor
There was a problem hiding this comment.
why have we used _ here with index?
Comment on lines
+16
to
+20
| <svg xmlns='http://www.w3.org/2000/svg' width='16' height='16' fill='#1d1283' viewBox='0 0 256 256'> | ||
| <path | ||
| d='M128,24A104,104,0,1,0,232,128,104.11,104.11,0,0,0,128,24Zm45.66,85.66-56,56a8,8,0,0,1-11.32,0l-24-24a8,8,0,0,1,11.32-11.32L112,148.69l50.34-50.35a8,8,0,0,1,11.32,11.32Z'> | ||
| </path> | ||
| </svg> |
Contributor
There was a problem hiding this comment.
Can we please use svg in img tag?
Comment on lines
+5
to
+9
| return 'completed'; | ||
| } else if (index === completedSteps) { | ||
| return 'active'; | ||
| } else { | ||
| return 'idle'; |
Contributor
There was a problem hiding this comment.
Can we please use enums (constants) here ?
Comment on lines
+24
to
+25
| background-color: #fff; | ||
| color: #999; |
Contributor
There was a problem hiding this comment.
Can we please use CSS variables here too ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue# Ref: [Identity Route] Stepper #353
Change:
The new Stepper component has been added to facilitate the display of completed steps in an ongoing process. It takes two input props:
totalStepsandcompletedSteps. ThetotalStepsprop determines the total number of steps in the component, while thecompletedStepsprop specifies the completed and active steps.The behavior of the component based on the range of values for
completedStepsis as follows:To ensure proper rendering and visibility of the component, both
totalStepsandcompletedStepsmust be provided as numeric values. If either prop is not a number, the component will not be rendered.This new Stepper component enhances the user experience by providing a visual representation of progress within a process.
Media/Screenshort
Screen.Recording.2023-05-25.at.12.20.51.AM.mp4
Checklist