Open
Conversation
swarajpure
reviewed
Apr 13, 2021
swarajpure
reviewed
Sep 26, 2021
swarajpure
suggested changes
Sep 26, 2021
Contributor
swarajpure
left a comment
swarajpure
left a comment
There was a problem hiding this comment.
Can we please fix the formatting issues? Also click is not being imported in a test file
swarajpure
reviewed
Oct 24, 2021
tests/acceptance/user-status-test.js
Outdated
| setupApplicationTest(hooks); | ||
|
|
||
| test('Should update the status on button clicks', async function (assert) { | ||
| await visit('/user-status'); |
Contributor
There was a problem hiding this comment.
This page will be behind authentication, right?
How do we know that the user has logged in?
ankushdharkar
added
feature task
ankushdharkar
requested review from
prakashchoudhary07
and removed request for
SagarBajpai
pallabez
reviewed
Jun 26, 2022
Comment on lines
23
to
50
| assert.equal( | ||
| this.element.querySelector('[data-test-mainHeading]').textContent.trim(), | ||
| 'Thank you for connecting your GitHub!', | ||
| 'Correct Heading' | ||
| ); | ||
| assert.equal( | ||
| this.element.querySelector('[data-test-subHeading]').textContent.trim(), | ||
| 'Please complete the signup in order to:', | ||
| 'Correct Subheading' | ||
| ); | ||
| assert.equal( | ||
| this.element.querySelector('[data-test-li1]').textContent.trim(), | ||
| 'Use Features', | ||
| 'Correct list item' | ||
| ); | ||
| assert.equal( | ||
| this.element.querySelector('[data-test-li2]').textContent.trim(), | ||
| 'Display yourself on the (members) page', | ||
| 'Correct list item' | ||
| ); | ||
| assert.equal( | ||
| this.element | ||
| .querySelector('[data-test-signup-button]') | ||
| .textContent.trim(), | ||
| 'Get Started', | ||
| 'Correct button title' | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Isn't checking if a specific keywords is present would be better here?
shubhamsinghbundela
force-pushed
the
test/user-status
branch
from
c5de75e to
47dd4c4
Compare
✅ Deploy Preview for staging-my ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing user-status component
/user-statusroute loads and has expected componentsAssumptions
/user-statusrouteButtoncomponentCloses #68