-
Notifications
You must be signed in to change notification settings - Fork 68
feat: Add "network" field to LlamaStackDistribution #2637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add "network" field to LlamaStackDistribution #2637
Conversation
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
WalkthroughThis PR adds an optional Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ocp_resources/llama_stack_distribution.py (1)
16-49: Generated code edited directly—update the generator instead.These changes are inside the generated-code block; per guidelines, modifications must be made in the class-generator and regenerated rather than editing the output file. As per coding guidelines, please update the generator and regenerate.
Short description:
Adding the new
networkfield to LlamaStackDistribution, which was added recently at github.com/llamastack/llama-stack-k8s-operator/pull/221)Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.