SMPP Server tests and extensions version fixes#294
Open
FerUy wants to merge 2 commits intoRestComm:masterfrom
Open
SMPP Server tests and extensions version fixes#294FerUy wants to merge 2 commits intoRestComm:masterfrom
FerUy wants to merge 2 commits intoRestComm:masterfrom
Conversation
zvikara
added a commit
to zvikara/smscgateway
that referenced
this pull request
Jan 24, 2019
…server tests. This fixes RestComm#294, fixes RestComm#295, fixes RestComm#296
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
smpp.extensions.version is set to latest correct available version.
Esme constructor in TxSmppServerSbbTest and RxSmppServerSbbTest classes is now fixed.
Because of these fixes, now SMSC Gw has no more compilation errors and builds successfully with all tests passing.