Open
Conversation
Member
|
Excellent job with this, looks great and works. I'm not sure I like having a class level instance variable for the movie to be able to say Instead, I would recommend creating a MovieHistory class that stories the values you wanted it to store. That way, your search remained just a search, while you can use that later to record a search. |
Author
|
I now use the MovieHistory class. |
Member
|
Cool --- I would move the calculations to the MovieHistory class as well --- you'll keep the collection, and the calculation, together. This would also keep the "movie" class pretty dumb -- which is how I like my data classes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Panda level finished.