Conversation
|
🏷️ [bumpr] |
Member
Author
|
@dulithaprasanna @sunerawijeratne Since you have repos that may use this reusable workflow, I wanted to request review from you as well to make sure you are okay with the changes and notify you that this is likely coming down the pipeline. Your current workflows will still work, but they won't test on all of the versions of Python or OSes that they did before by default. Perhaps it would be best to add an example workflow file that can be easily copy-pasted to other projects to make the change easier. I'll try that and see if it causes issues to add it here. |
This was referenced Jul 2, 2025
JohnBrittaein
approved these changes
Jul 2, 2025
dulithaprasanna
approved these changes
Jul 2, 2025
|
🚀 [bumpr] Bumped! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Right now, the workflow for Python unit testing via tox is hard-coded to use Python versions 3.9 and 3.11. Python 3.9 is reaching EOL soon and Python 3.12 and 3.13 have both been released as higher stable versions. Our reusable workflow needs to be more flexible to allow different projects to use it to test against different Python versions. Since it is the same pattern, I also made the test platforms configurable through an input value.
This is going to change the behavior of the workflow in any repos that currently refer to this workflow, so I have compiled a list of our repos that need to be updated. However, none of them are public at the moment, so please reach out if you need the list of repos to be converted.
TODOs