Bugifx/acastill realistic pmt#891
Conversation
…ducer order in standard detsim
`fPositivePolarity` is inferred during configuration
lynnt20
left a comment
There was a problem hiding this comment.
Approved, also pushed a couple changes myself:
- updated pmtmcmetric input label to be with the pulse oscillations.
- removed some unused variables mentioned in last major PR #876 by @fjnicolas.
Would be good to get @fjnicolas's review before merging.
fjnicolas
left a comment
There was a problem hiding this comment.
Thanks @asanchezcastillo! Looks good from my side and all the changes match the PR description :)
|
trigger build ci_ref=v10_14_00_01 LArSoft/lar*@LARSOFT_SUITE_v10_14_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
Approved! |
Description
This PR does:
ScintPreScaleto reflect the updated value of the PMT detection efficiencies.pds_calibration.dbfile.Please provide a detailed description of the changes this pull request introduces.
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
This PR is to be merged with SBNSoftware/sbnd_data#8
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?