Light Calorimetry: Add obj for light calo objects#158
Light Calorimetry: Add obj for light calo objects#158
Conversation
Version v09_19_00_01, patch release for SBN2024A
update lardataobj dependency
sbnobj v10_00_08 for sbncode v10_04_07
sbnobj v10_00_10 for sbnalg v10_05_00
sbnobj v10_01_01 for sbnalg v10_06_00_03
sbnobj v10_03_00 for sbnalg v10_11_01
|
@lynnt20 could you nominate reviewers please? |
PetrilloAtWork
left a comment
PetrilloAtWork
left a comment
There was a problem hiding this comment.
The class version business must be fixed.
I have left also a technical C++ comment: fell completely free to decide how to approach it.
|
Hi @PetrilloAtWork, thank you for all your comments and suggestions! I believe I've implemented all the changes now: I've added the class versions and checksums for all the new classes, and also removed the value constructor (go back to "plain old data" class). |
PetrilloAtWork
left a comment
PetrilloAtWork
left a comment
There was a problem hiding this comment.
I have left two completely optional comments, but the PR is approved.
| */ | ||
|
|
||
| struct LightCalo { | ||
| public: |
There was a problem hiding this comment.
This is now redundant (struct members are public by default).
| public: | ||
|
|
||
| // NaN value to initialize data members | ||
| static constexpr double nan = std::numeric_limits<double>::signaling_NaN(); |
There was a problem hiding this comment.
Somehow the capitalisation NaN is so "standard" that even C++, that uses all small letters, uses it. Consider replacing nan with NaN.
linyan-w
moved this from Expected for Later
to Reviewer Approved
in SBND 2025 Fall Production
3 participants
Accompanying PRs: SBNSoftware/sbndcode#878, SBNSoftware/sbncode#619, SBNSoftware/sbnanaobj#181