RTPStream: Remove dead code #847
Open
+0
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SRTP params are printed once in rtpstream_set_srtp_*. After that, the file is closed and assigned null, so these calls are always no-op.
Contributor
Author
|
@jeannotlanglois Please approve (or explain, if the mistake is elsewhere :)) |
There was a problem hiding this comment.
Pull request overview
This pull request removes dead code related to SRTP parameter debugging. The removed function calls were no-ops because they attempted to print to debug files that had already been closed and set to null in earlier rtpstream_set_srtp_* functions.
Changes:
- Removed 12 no-op function calls (6 pairs of printLocal/printRemote calls) from RTP echo functions
- The print functions check for null file handles before writing, so these calls never produced output
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SRTP params are printed once in rtpstream_set_srtp_*. After that, the file is closed and assigned null, so these calls are always no-op.