Skip to content

Conversation

@aborah-sudo
Copy link
Contributor

Add context manager to BaseLinuxHost that temporarily sets SELinux to permissive mode for tests. This is needed for proxy provider tests that use nslcd (nss-pam-ldapd), as this test-only configuration lacks proper SELinux policies in enforcing mode.

@gemini-code-assist
Copy link

Summary of Changes

Hello @aborah-sudo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a new context manager to the BaseLinuxHost class, designed to temporarily switch SELinux to permissive mode for specific test scenarios. This is particularly useful for proxy provider tests that rely on nslcd and encounter failures due to missing SELinux policies in enforcing mode. The context manager ensures that the SELinux state is safely restored after the test, providing a controlled environment for these sensitive tests.

Highlights

  • New Context Manager: Introduced a new context manager, selinux_permissive_for_test, within the BaseLinuxHost class.
  • SELinux Mode Control: This context manager temporarily sets SELinux to permissive mode for the duration of its block and ensures it is reverted to enforcing mode afterwards, if it was originally enforcing.
  • Test Environment Support: The feature addresses issues in proxy provider tests that use nslcd (nss-pam-ldapd), which lack proper SELinux policies in enforcing mode, allowing these tests to run successfully.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a helpful context manager to temporarily set SELinux to permissive mode during tests. The implementation is straightforward and correctly handles scenarios where SELinux is not in enforcing mode. My review includes one suggestion to enhance the robustness of the cleanup logic, ensuring that a failure to restore the SELinux state doesn't halt the entire test suite.

Add context manager to BaseLinuxHost that temporarily sets SELinux
to permissive mode for tests. This is needed for proxy provider tests
that use nslcd (nss-pam-ldapd), as this test-only configuration lacks
proper SELinux policies in enforcing mode.
Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jakub-vavra-cz jakub-vavra-cz merged commit 8b67882 into SSSD:master Jan 13, 2026
6 checks passed
@aborah-sudo aborah-sudo deleted the add_selinux branch January 13, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants