-
Notifications
You must be signed in to change notification settings - Fork 271
FreeBSD CI: Switch to 15.0-RELEASE and enable testing #8306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
.github/workflows/build.yml
Outdated
| echo "::group::Testing" | ||
| # Tests don't work yet | ||
| #gmake check | ||
| gmake -j $(sysctl -n hw.ncpu) check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if '-j' will be "stable" but let's see...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linux jobs seem to run tests with -j
sssd/.github/workflows/build.yml
Line 41 in 2b43681
| make CFLAGS+="$SSS_WARNINGS -Werror" -j$PROCESSORS check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I wonder if it was the reason of randomly failing
https://github.com/SSSD/sssd/actions/runs/19703082331/job/56443862911
|
Why doesn't FreeBSD CI run automatically? |
Some CI jobs require manual approval by a maintainer with write access. |
|
Can the FreeBSD build be restarted, please? It failed due to a temporary fluke on the FreeBSD pkg repository side. |
|
Thanks. I'll work on the last test failure, although I can't reproduce it locally. |
|
I finally managed to get |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the FreeBSD CI to use 15.0-RELEASE and enables testing. The changes include updating shebangs in shell scripts for better portability, adjusting a test assertion to be compatible with FreeBSD, and temporarily disabling a few tests that are failing on the FreeBSD CI environment.
My main feedback is regarding a misleading comment for one of the disabled tests. It's important to have accurate comments, especially when disabling tests, to help future developers understand the context. It would also be beneficial to add comments to the other disabled tests for the same reason.
Overall, the changes look good and are aligned with the goal of improving FreeBSD CI support.
|
Logs of failing (disabled) pam-srv tests:
|
|
|
Common point of failure: @sumit-bose, would you have an idea how to debug this further? |
|
Hi, I think is unexpected by the test. Is there a process runnig with UID 123 on the system where the test is running? Does it help if you give bye, |
Thank you. @arrowd, could you please try this instead of disabling tests? |
What a sharp eye you have! UID 123 on FreeBSD is the |
Looks fine now. @arrowd, could you please remove |
sumit-bose
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
I have no further comments, ACK.
bye,
Sumit
|
Btw, 'sssd-2.12.0' is out, so maybe https://www.freshports.org/security/sssd2 could be updated to use it :) |
Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com>
Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com>
Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com>
Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com>
Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com>
…r port does Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com>
Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com>
On FreeBSD the UID 123 corresponds to the built-in ntpd user and the machine that runs this test may be running the ntpd daemon. Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com>
Oh, that's a shame, I wanted this PR to get in before the release. Anyways, this PR concludes my upstreaming efforts. Please get me on the hook whenever FreeBSD CI start to fail. And thanks for merging all our patches too! |
Well, at least this PR didn't touch "product" code, only a couple of tests... |
No description provided.