Skip to content

Conversation

@sssd-bot
Copy link
Contributor

This is an automatic backport of PR#8379 tests: python black 26.1.0 style changes to branch sssd-2-8, created by @justin-stephenson.

Caution

@justin-stephenson The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with CONFLICT!.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8379-to-sssd-2-8
git checkout SSSD-sssd-backport-pr8379-to-sssd-2-8
git push sssd-bot SSSD-sssd-backport-pr8379-to-sssd-2-8 --force

Original commits
96829a0 - tests: python black 26.1.0 style changes

Backported commits

  • c64560d - CONFLICT! tests: python black 26.1.0 style changes

Conflicting Files Information (check for deleted and re-added files)

  • CONFLICT! tests: python black 26.1.0 style changes
On branch SSSD-sssd-backport-pr8379-to-sssd-2-8
You are currently cherry-picking commit 96829a000.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   src/tests/system/tests/test_kcm.py
	deleted by us:   src/tests/system/tests/test_pysss_nss_idmap.py

no changes added to commit (use "git add" and/or "git commit -a")

Original Pull Request Body

Adapt to changes from https://github.com/psf/black/releases/tag/26.1.0

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request backports Python test changes, including adapting to black version 26.1.0 style and adding new tests for pysss_nss_idmap.

My review has identified a critical merge conflict in src/tests/system/tests/test_kcm.py that must be resolved.

Additionally, I've found two high-severity potential command injection vulnerabilities in the new test file src/tests/system/tests/test_pysss_nss_idmap.py due to unsafe string formatting when constructing shell commands. I have provided suggestions to mitigate these risks.

Please address these points to ensure the stability and security of the test suite.

@justin-stephenson justin-stephenson force-pushed the SSSD-sssd-backport-pr8379-to-sssd-2-8 branch from c64560d to 60de504 Compare January 19, 2026 20:03
Adapt to changes from https://github.com/psf/black/releases/tag/26.1.0

Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Reviewed-by: Scott Poore <spoore@redhat.com>
(cherry picked from commit 96829a0)
@justin-stephenson justin-stephenson force-pushed the SSSD-sssd-backport-pr8379-to-sssd-2-8 branch from 60de504 to cba688a Compare January 19, 2026 20:06
@justin-stephenson justin-stephenson marked this pull request as ready for review January 19, 2026 20:20
justin-stephenson and others added 4 commits January 20, 2026 09:00
These were moved in
SSSD/sssd-test-framework@bad7103

Reviewed-by: Dan Lavu <dlavu@redhat.com>
(cherry picked from commit 5aa8c23)
If the integration tests fail during one of the initial steps 'install-deps'
or 'autoreconf.log' there are no logs to debug the issue. This patch
adds the related logs to the artifacts.

Reviewed-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Pavel Březina <pbrezina@redhat.com>
(cherry picked from commit b17c6c5)
@justin-stephenson justin-stephenson force-pushed the SSSD-sssd-backport-pr8379-to-sssd-2-8 branch from 8d8a0b1 to 35b8224 Compare January 20, 2026 14:22
This does not work on Fedora 41, it looks like it is not supported
by dnf5.

Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Reviewed-by: Sumit Bose <sbose@redhat.com>
(cherry picked from commit fad092b)
@justin-stephenson justin-stephenson force-pushed the SSSD-sssd-backport-pr8379-to-sssd-2-8 branch from 35b8224 to 990aa1c Compare January 20, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants