-
Notifications
You must be signed in to change notification settings - Fork 271
[autobackport: sssd-2-8] tests: python black 26.1.0 style changes #8384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sssd-2-8
Are you sure you want to change the base?
[autobackport: sssd-2-8] tests: python black 26.1.0 style changes #8384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request backports Python test changes, including adapting to black version 26.1.0 style and adding new tests for pysss_nss_idmap.
My review has identified a critical merge conflict in src/tests/system/tests/test_kcm.py that must be resolved.
Additionally, I've found two high-severity potential command injection vulnerabilities in the new test file src/tests/system/tests/test_pysss_nss_idmap.py due to unsafe string formatting when constructing shell commands. I have provided suggestions to mitigate these risks.
Please address these points to ensure the stability and security of the test suite.
c64560d to
60de504
Compare
Adapt to changes from https://github.com/psf/black/releases/tag/26.1.0 Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Scott Poore <spoore@redhat.com> (cherry picked from commit 96829a0)
60de504 to
cba688a
Compare
These were moved in SSSD/sssd-test-framework@bad7103 Reviewed-by: Dan Lavu <dlavu@redhat.com> (cherry picked from commit 5aa8c23)
If the integration tests fail during one of the initial steps 'install-deps' or 'autoreconf.log' there are no logs to debug the issue. This patch adds the related logs to the artifacts. Reviewed-by: Justin Stephenson <jstephen@redhat.com> Reviewed-by: Pavel Březina <pbrezina@redhat.com> (cherry picked from commit b17c6c5)
8d8a0b1 to
35b8224
Compare
This does not work on Fedora 41, it looks like it is not supported by dnf5. Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com> (cherry picked from commit fad092b)
35b8224 to
990aa1c
Compare
This is an automatic backport of PR#8379 tests: python black 26.1.0 style changes to branch sssd-2-8, created by @justin-stephenson.
Caution
@justin-stephenson The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with
CONFLICT!.You can push changes to this pull request
Original commits
96829a0 - tests: python black 26.1.0 style changes
Backported commits
Conflicting Files Information (check for deleted and re-added files)
Original Pull Request Body
Adapt to changes from https://github.com/psf/black/releases/tag/26.1.0