[autobackport: sssd-2-12] Add GDM Smartcard tests #8390
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces GDM Smartcard tests and refines the existing GDM passkey tests. The modifications to the passkey tests, such as removing time.sleep calls and adding explicit waits with assert_text, are excellent improvements for test stability and reliability. The new smartcard tests are a valuable addition. However, I've identified one area for improvement in the new test file where a time.sleep() has been introduced, which could lead to test flakiness.
(cherry picked from commit f8c281c) Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Madhuri Upadhye <mupadhye@redhat.com>
Also removing unused GenericProvider references and update some docstrings. (cherry picked from commit d78e326) Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Madhuri Upadhye <mupadhye@redhat.com>
Renaming test_gdm.py to test_gdm_xidp.py to align with the other test_gdm_* test modules. Also adding authselect for with-switchable-auth which is needed to configure the system for GDM to use the new switchable authentication mechanisms. (cherry picked from commit 7f78c93) Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Madhuri Upadhye <mupadhye@redhat.com>
|
The pull request was accepted by @madhuriupadhye with the following PR CI status: 🟢 rpm-build:centos-stream-10-x86_64:upstream (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
sssd-bot
force-pushed
the
SSSD-sssd-backport-pr8216-to-sssd-2-12
branch
from
2505b8f to
551308c
Compare
4 participants
This is an automatic backport of PR#8216 Add GDM Smartcard tests to branch sssd-2-12, created by @spoore1.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
f8c281c - Tests: Add GDM Smartcard tests
d78e326 - Tests: gdm passkey fixes for timing issues in c10s
7f78c93 - Tests: rename and update test_gdm to xidp
Backported commits
Original Pull Request Body