Closed
Conversation
Makes the API easier to use, and means there are less safety requirements that we have to document.
Author
|
Ooops, accidentally deleted the branch, so I've created #98 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smart pointer version of
StrongPtr, but with more guarantees.Notably, this has an
Deref<Target = T>implementation, which makes it more ergonomic and safer to use.See #95 for some of the reasoning behind this.
I'm thinking about removing
StrongPtrcompletely in favor of this (since it's behaviour can be achieved withRetained<Object>), but please voice your opinion on this.