-
Notifications
You must be signed in to change notification settings - Fork 3
Full name for quantity #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rprospero
wants to merge
11
commits into
refactor_24
Choose a base branch
from
full-name-for-quantity-97
base: refactor_24
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+107
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1fe4a5 to
7c2cfc3
Compare
97b026a to
add8642
Compare
add8642 to
d09ef88
Compare
d09ef88 to
0f013b1
Compare
0f013b1 to
9eea1b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No quality gates enabled for this code.
See analysis details in CodeScene
Quality Gate Profile: Custom Configuration
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a human readable unique id for the data sets in a dataset. The general format that we use is "RUN TITLE:RUN NUMBERS:DATASET DESCRIPTION:BASE62 ENCODED HASH OF DATA". As an example, the unique id for the Q data in
cansas1d.xmlis "Test title:1234:Q:440tNBqdx9jvci6CgjmrmD".The hash is included to ensure that different data always have a different unique_id, even if they have identical metadata. Base 62 was chosen to provide a more compact representation (44% shorter) of the hash than just writing out the integer.
This closes #97.