Skip to content

use http_build_query for query string creation#1

Open
austinpray wants to merge 1 commit intoScreenshotsCloud:masterfrom
oncarrot:http_build_query
Open

use http_build_query for query string creation#1
austinpray wants to merge 1 commit intoScreenshotsCloud:masterfrom
oncarrot:http_build_query

Conversation

@austinpray
Copy link

Use https://www.php.net/manual/en/function.http-build-query.php to build the query string

  • well defined behavior
  • benefits from updates and bug fixes to PHP in the future
  • simplifies the source

what's not to love?

@Bantam
Copy link
Contributor

Bantam commented Nov 16, 2019

Thanks Austin, we'll test this and look towards merging next week!

@austinpray
Copy link
Author

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants