Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description / Link to Ticket
This pull request adds support for managing PayID registrations in the Zai Payment library. The main changes introduce a new resource class for PayID operations, update the main module to expose this resource, and ensure the response handler recognizes PayID data.
PayID resource integration:
ZaiPayment::Resources::PayIdclass (lib/zai_payment/resources/pay_id.rb) that provides methods to register, show, and deregister PayIDs for virtual accounts, including input validation and request construction.ZaiPaymentmodule to require the new PayID resource and provide apay_idsaccessor for users to interact with PayID operations. [1] [2]Response handling:
Responseclass to recognizepay_idsas a top-level data key, ensuring PayID API responses are parsed correctly.Testing
Additional Notes