Adjusted clip player to changed Twitch Clip URI#15
Open
Shaarigan wants to merge 2 commits intoShaderWave:mainfrom
Open
Adjusted clip player to changed Twitch Clip URI#15Shaarigan wants to merge 2 commits intoShaderWave:mainfrom
Shaarigan wants to merge 2 commits intoShaderWave:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Twitch change dtheir URI format, the clip player broke for clips created after that change. I adjusted the player to the new changes by making use of the GraphQL API. A simple request to obtain a token for the clip was added and then a matching URI is created that works for both, old and new clips
This fixes issue #14