WIP: Add integration test on #5
Open
satos---jp wants to merge 6 commits intoSoftwareFoundationGroupAtKyotoU:mainfrom
Open
WIP: Add integration test on #5satos---jp wants to merge 6 commits intoSoftwareFoundationGroupAtKyotoU:mainfrom
satos---jp wants to merge 6 commits intoSoftwareFoundationGroupAtKyotoU:mainfrom
Conversation
added 6 commits
September 14, 2024 17:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
このPRは途中です。テスト通ってるように見えますがまだ壊れている(キャッシュのために通している)のでマージしないでください
Mac用のintegration testのPRの途中です。 #4 の上に作っています。
ModuleNotFoundError: No module named 'setuptools'で落ちるのでpip install setuptoolsしています。(Ubuntuのときは不要でした)pip listするとなぜかaalpyが3つインストールされています(なぜ...?)pip installに失敗したのでrequirements.txt記載のバージョンを今pip installで自動的に入るものに上げました。エラーについて
python3 src/main.py ...時に以下のエラーで落ちます。for e in edges: passの途中で落ちてるみたいです。edges変数はspotライブラリから提供されるPythonでラップされたなんらかのC++構造体ぽくて、spotのバグであるかどうかは調査の必要ありそうです。(temporary fixのやつが何かわるさしている可能性もあると思います)