engine: reduce CBaseClient size & move scratch buffer#162
Open
RaphaelIT7 wants to merge 3 commits intoSource-Authors:masterfrom
Open
engine: reduce CBaseClient size & move scratch buffer#162RaphaelIT7 wants to merge 3 commits intoSource-Authors:masterfrom
RaphaelIT7 wants to merge 3 commits intoSource-Authors:masterfrom
Conversation
dimhotepus
force-pushed
the
master
branch
5 times, most recently
from
739a853 to
a997975
Compare
dimhotepus
force-pushed
the
master
branch
2 times, most recently
from
a237f58 to
6699560
Compare
dimhotepus
force-pushed
the
master
branch
2 times, most recently
from
1319e7e to
08258ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still needs testing.Moved the scratch buffer to be inside
SendSnapshotas it greatly reduces the size of the class and saves memory.This is because it's only used to send snapshots - for that we can just allocate it once per thread and reuse it instead of having one per client.
It's more likely to have way more clients than threads so it'll save memory.