Migrate socket tickets API to new router

[tudddorrr]

No description provided.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.43%. Comparing base (204241b) to head (50ba049).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #796      +/-   ##
===========================================
+ Coverage    98.35%   98.43%   +0.07%     
===========================================
  Files          327      327              
  Lines        18917    18927      +10     
  Branches      1772     1768       -4     
===========================================
+ Hits         18606    18630      +24     
+ Misses         303      289      -14     
  Partials         8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[claude]

🔴 Code Quality & Best Practices

Bug in documentation.service.ts (line 43-45)

The enrichDocsWithScopes method will crash when it encounters services registered via the new router pattern (like SocketTicketAPIService):

for (const service of services) {
  const apiDocs = docsMap[service.name as keyof typeof docsMap]
  for (const route of service.routes) {
    const match = Object.values(apiDocs).find(  // ❌ apiDocs is undefined
      (doc) => doc?.description === route.description && doc.scopes
    )

When SocketTicketAPIService is registered via docsKey, it won't exist in docsMap (since you removed SocketTicketAPIDocs from src/docs/). Calling Object.values(undefined) throws a TypeError.

Fix: Add a guard check:

for (const service of services) {
  const apiDocs = docsMap[service.name as keyof typeof docsMap]
  if (!apiDocs) continue  // Skip services not in docsMap
  
  for (const route of service.routes) {
    const match = Object.values(apiDocs).find(
      (doc) => doc?.description === route.description && doc.scopes
    )

---

✅ Potential Bugs

No other issues found.

---

✅ Performance

No issues found.

---

✅ Security

No issues found.

---

✅ Test Coverage

Good improvement! The new tests verify both normal and dev build tickets by checking Redis payload, which is more thorough than the old implementation.