Validate loader branch syntax#2
Merged
cam72cam merged 1 commit intoTeamOpenIndustry:masterfrom Jun 12, 2023
Merged
Conversation
Contributor
Author
Member
|
Sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the jar for the first time, there are no hints as to why it fails if you don't provide any arguments. If you do provide an argument, there are no hints as to why it's invalid. This PR first checks that an argument is provided, and mentions what it should be. It then checks its syntax to make sure it's at least sane before trying to fetch the git branch.