[WIP] injected angularjs dependencies#969
Open
gnehapk wants to merge 2 commits intoTendrl:react-migrationfrom
Open
[WIP] injected angularjs dependencies#969gnehapk wants to merge 2 commits intoTendrl:react-migrationfrom
gnehapk wants to merge 2 commits intoTendrl:react-migrationfrom
Conversation
Member
Author
|
Completed following tasks-
Pending -
@shirshendu Please review. |
shirshendu
suggested changes
Jun 12, 2018
src/commons/services/utils.js
Outdated
| //url = "/api/events.json"; | ||
| url = config.baseUrl + "clusters/" + clusterId + "/notifications"; | ||
| url = "/api/events.json"; | ||
| //url = config.baseUrl + "clusters/" + clusterId + "/notifications"; |
There was a problem hiding this comment.
I thought this change only helps with testing. Should it be here?
Member
Author
There was a problem hiding this comment.
@shirshendu Yes, its just for testing. I will remove it.
gnehapk
force-pushed
the
migrate-to-react
branch
from
5b7265e to
f4e14eb
Compare
2) Implemented Pub/Sub Model 3) Implemented event list view in react Signed-off-by: Neha Gupta <gnehapk@gmail.com>
gnehapk
force-pushed
the
migrate-to-react
branch
from
f4e14eb to
db6cd72
Compare
Member
Author
|
@shirshendu I have amended the PR. Please review. |
shirshendu
approved these changes
Jun 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem - angularjs dependencies are getting injected after the code which read it.
In my code, statement
const { $rootScope, $state, $q, $http } = ngDeps;insideevent-store.jsfile is getting executed before the run module's callback, where we are injecting the dependencies(inside ng-react-ng-deps.js). Hence, thengDepsis not getting updated with the dependencies. For the 1st time, when application gets displayed in browser, we can see the dependencies insidengDeps(but still $q.defer is undefined) and if you refresh the page,ngDepsgets blank again because of the above mentioned issue.Hence, for now required angularjs dependencies are added on
windowobject and accessed via window object only.@shirshendu ^^