Redesign of Julia interop, avoiding Jupyter kernel#835
Redesign of Julia interop, avoiding Jupyter kernel#835kris-brown wants to merge 9 commits intomainfrom
Conversation
epatters
force-pushed
the
update-cclinterop-types
branch
from
967ea9f to
113a4f8
Compare
kris-brown
force-pushed
the
interop_refactor
branch
from
b9eb474 to
4d6e69e
Compare
kris-brown
force-pushed
the
interop_refactor
branch
from
4d6e69e to
3b4ce9b
Compare
kris-brown
force-pushed
the
interop_refactor
branch
from
34dadc8 to
5d8dd71
Compare
kasbah
left a comment
kasbah
left a comment
There was a problem hiding this comment.
Some more CORS fixups for you.
|
Thanks, these are addressed now! |
epatters
left a comment
epatters
left a comment
There was a problem hiding this comment.
Thanks Kris and Matt, it'll be great to have a simpler and more flexible approach to interop with Julia. Some comments below.
kris-brown
force-pushed
the
interop_refactor
branch
from
b7049e2 to
3308189
Compare
|
Thanks! I believe your suggested changes have all been incorporated. However, I'm not sure how to test whether the |
CLEANUP: changing tests CLEANUP: reorganized code into parse and execute folders refactor algjuliainterop CORS and async issues resolved basic tabular view functionality edit remove decapodes material run formatter docs fix using local version remove axios undo changes newlines remove space More docs
epatters
force-pushed
the
interop_refactor
branch
from
8d55603 to
0c108c1
Compare
Also, fix a lint about the type `{}` in TypeScript.
epatters
left a comment
epatters
left a comment
There was a problem hiding this comment.
Thanks Kris, this is looking really close to ready!
| return ( | ||
| <div class="simulation"> | ||
| <PanelHeader title="Tabular view" /> | ||
| <For each={model?.obGenerators()}>{(ob) => createACSetTable(model, rawdata, ob)}</For> |
There was a problem hiding this comment.
Looks like we're calling a function to create JSX elements instead of using a component, which is rarely what you want to do as it can cause reactivity problems. @kasbah, can you help Kris restructure this code into components?
| <Match when={res()}> | ||
| {(data) => { | ||
| const result = data(); | ||
| return <div>{createACSet(result.model, result.data)}</div>; |
4 participants
This PR simplifies a lot of the structure of the CatColabInterop.jl package.
It introduces a new analysis of schema instances by sending the diagram to Catlab, where it is processed by
@acset_colimto produce a tabular instance.(This is currently a WIP - once the workflow is working for the tabular view analysis, the existing Decapodes analysis will be brought back into functionality).