Repairing tests that were failing due to recent contributions #1157
+37
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Gemma3 feature - rigidity of test_cross_attention confidence testing reduced slightly - updated ActivationCache to ensure the `tokens` variable maintains the correct type for the `tokens_to_residual_directions` functions - Fixed type checking bug in `transformer_lens/utilities/devices.py`
This reverts commit 8c59925.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several tests were failing due to the unique situations posed by the Gemma3 model integration.
test_cross_attentionconfidence testing reduced slightlyActivationCacheto ensure thetokensvariable maintainsInttyping fortokens_to_residual_directionstransformer_lens/utilities/devices.pythrown bybeartypechecks.ymlfile that cause issues with incompatible hugging face versionsType of change
Please delete options that are not relevant.
Checklist: