Skip to content

Conversation

@YousefED
Copy link
Collaborator

Summary

The showSelection(false) effect cleanup in the Link button was interfering with the AI extension. What happened:

  • formatting toolbar opens
  • user clicks AI Extension
  • AI Extension opens and sets showSelection(true)
  • Formatting toolbar closes and link button unmounts, calling showSelection(false)

Rationale

This keys the showSelection by "consumer". @nperez0111 let me know what you think if this, open to other solutions

Changes

Impact

Testing

Manual

Checklist

  • Code follows the project's coding standards.
  • Unit tests covering the new feature have been added.
  • All existing tests pass.
  • The documentation has been updated to reflect the new feature

@vercel
Copy link

vercel bot commented Dec 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
blocknote Ready Ready Preview Dec 16, 2025 11:46am
blocknote-agent-demo Error Error Dec 16, 2025 11:46am
blocknote-website Ready Ready Preview Dec 16, 2025 11:46am

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 16, 2025

Open in StackBlitz

@blocknote/ariakit

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/ariakit@2297

@blocknote/code-block

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/code-block@2297

@blocknote/core

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/core@2297

@blocknote/mantine

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/mantine@2297

@blocknote/react

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/react@2297

@blocknote/server-util

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/server-util@2297

@blocknote/shadcn

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/shadcn@2297

@blocknote/xl-ai

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-ai@2297

@blocknote/xl-docx-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-docx-exporter@2297

@blocknote/xl-email-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-email-exporter@2297

@blocknote/xl-multi-column

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-multi-column@2297

@blocknote/xl-odt-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-odt-exporter@2297

@blocknote/xl-pdf-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-pdf-exporter@2297

commit: 522a939

Copy link
Contributor

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer a slightly different approach here:

commands:

  • showSelection(key: string)
  • hideSelection(key: string)

But, honestly it is a minor thing. I would probably revisit the naming of this altogether on second though. Like PreserveSelectionExtension with show & hide methods

But, I'd rather just fix the bug for now and revisit later

@nperez0111 nperez0111 merged commit 049af21 into main Jan 8, 2026
9 of 10 checks passed
@nperez0111 nperez0111 deleted the fix/ai-show-selection branch January 8, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants