fix error message and button on auth-ldap-page#393
Open
koctuk999 wants to merge 1 commit intoVKCOM:masterfrom
Open
fix error message and button on auth-ldap-page#393koctuk999 wants to merge 1 commit intoVKCOM:masterfrom
koctuk999 wants to merge 1 commit intoVKCOM:masterfrom
Conversation
koctuk999
force-pushed
the
ksolow/fixLdapAuthPage
branch
from
52c4a15 to
27babd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was that authentication errors were not displayed, and the login button was not disabled during the execution of the request.
After fix:
Show error message after login
Disable button during processing request
