This repository was archived by the owner on Sep 28, 2021. It is now read-only.
Conversation
pmather
reviewed
Aug 12, 2019
Collaborator
pmather
left a comment
pmather
left a comment
There was a problem hiding this comment.
This looks like more than just an update of the gems currently flagged as having security vulnerabilities (actionview, mini_magick, devise, and bootstrap-sass). It includes an update of Hyrax to 2.2. You should be more explicit about this in the commit/PR message. (In the past, we've just done conservative updates for vulnerable gems, e.g., something along the lines of bundle update actionview mini_magick devise bootstrap-sass which will minimally update the affected gems and associated dependencies. It's not clear in that context why an update of the hyrax gem was necessary.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update gems to address security issues.
JIRA Ticket: (https://webapps.es.vt.edu/jira/browse/LIBTD-1869) (:star:)
What does this Pull Request do? (:star:)
Update gems to address security issues.
What's the changes? (:star:)
How should this be tested?
ruby_version: '2.4'in Installscripts/ansible/site_secrets.ymlgem_updatesbranch and ensure that application is still functionalAdditional Notes:
Interested parties
@pmather
(:star:) Required fields