implement "AllowSidegrade" functionality in Hand.cs#384
Open
rrkpp wants to merge 1 commit intoValveSoftware:masterfrom
Open
implement "AllowSidegrade" functionality in Hand.cs#384rrkpp wants to merge 1 commit intoValveSoftware:masterfrom
rrkpp wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, maybe I'm mistaken but I found that the "AllowSidegrade" AttachmentFlag isn't actually referenced anywhere in the SteamVR plugin. This PR implements the AllowSidegrade flag in Hand.cs : IsGrabEnding() how I imagine it was intended: if the attachedObject being checked has the AllowSidegrade flag, it'll check if the Hand is grabbing with either grip type. If the object doesn't have the flag, the original logic will apply, and it'll check if the Hand is grabbing with the 'grabbedWithType' of the attachedObject.