Use mapped HGNC name for assay facts gene text when available #597
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves how gene information is displayed in the
AssayFactSheet.vuecomponent. The main focus is to show a clearer and more accurate gene label, handling cases where multiple genes are present or a gene is not specified. This display will now also pull first from themappedHgncNameproperty, which is based on a more robust HGNC selection strategy as described in VariantEffect/dcd_mapping2#67.Gene display improvements:
distinctGenesForTargets, to extract unique mapped HGNC gene names fromtargetGenes, filtering out empty values.geneTextForScoreSet, which usesdistinctGenesForTargetsto determine the gene text: if no mapped gene names are available, it falls back to the original gene name; if there is one unique gene, it displays that; if there are multiple, it displays "Multiple genes".geneTextForScoreSet, defaulting to "Not specified" if no gene is available.Related code updates:
geneAndYearcomputed property to usegeneTextForScoreSetfor consistency in gene name display.