feat: add modifier for min income to make conversions easier on ethereum#68
Open
feat: add modifier for min income to make conversions easier on ethereum#68
Conversation
coreyar
force-pushed
the
add-min-income-modifier
branch
from
22eeeda to
4772cb4
Compare
coreyar
force-pushed
the
add-min-income-modifier
branch
from
4772cb4 to
bb9e4cb
Compare
coreyar
force-pushed
the
add-min-income-modifier
branch
from
bb9e4cb to
9cacb77
Compare
kkirka
reviewed
Dec 17, 2024
| description: "Min income in basis points as percentage of amount", | ||
| alias: "bp", | ||
| description: | ||
| "Increase the min income offered to make swaps more likely to succeed. If min income is negative this will increase the amount offered in the swap. If the min the min income is positive this will accept a lower profit.", |
Contributor
There was a problem hiding this comment.
Suggested change
| "Increase the min income offered to make swaps more likely to succeed. If min income is negative this will increase the amount offered in the swap. If the min the min income is positive this will accept a lower profit.", | |
| "Increase the min income offered to make swaps more likely to succeed. If min income is negative this will increase the amount offered in the swap. If the min income is positive this will accept a lower profit.", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an option to modify the min income to allow for more slippage when making conversions