Conversation
chechu
reviewed
May 8, 2025
| params: [DEFAULT_ADMIN_ROLE, ACM_AGGREGATOR], | ||
| dstChainId: LzChainId.unichainsepolia, | ||
| }, | ||
| ...setConverterNetworkCommands, |
Contributor
There was a problem hiding this comment.
I miss:
- configuration of rules in the PSR: addOrUpdateDistributionConfigs.
Schema 0:
Treasury: 60%
XVSVaultConverter: 20%
USDCPrimeConverter: 10%
WETHPrimeConverter: 10%
Schema 1:
Treasury: 80%
XVSVaultConverter: 20%
- commands to configure the conversions on each converter:
setConversionConfigs(address,address[],(uint256,uint8)[]). You can check the VIP where Prime was enabled on Arbitrum: https://github.com/VenusProtocol/vips/blob/main/vips/vip-400/bscmainnet.ts
vips/vip-501/bsctestnet.ts
Outdated
Comment on lines
59
to
64
| { | ||
| target: unichainsepolia.XVS_VAULT_PROXY, | ||
| signature: "setPrimeToken(address,address,uint256)", | ||
| params: [PRIME, unichainsepolia.XVS, PRIME_POOL_ID], | ||
| dstChainId: LzChainId.unichainsepolia, | ||
| }, |
Contributor
There was a problem hiding this comment.
I think this has been already done, here: https://github.com/VenusProtocol/vips/blob/main/multisig/proposals/unichainsepolia/vip-006/index.ts#L110-L114
Contributor
|
We are adding new markets to unichain. We should take that into account to configure the conversions. See here: #561 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves VEN