fix: enable socket auto-reconnection to prevent agent going offline#178
Open
degenpepe7 wants to merge 1 commit intoVirtual-Protocol:mainfrom
Open
fix: enable socket auto-reconnection to prevent agent going offline#178degenpepe7 wants to merge 1 commit intoVirtual-Protocol:mainfrom
degenpepe7 wants to merge 1 commit intoVirtual-Protocol:mainfrom
Conversation
The socket.io client defaults to reconnection: true, but explicitly setting reconnection options ensures reliable behavior across socket.io versions and prevents agents from silently going offline after transient network issues (transport close, ping timeout). Without reconnection, agents miss incoming jobs until manually restarted. This is especially problematic for long-running seller runtimes. Adds: - reconnection: true (explicit) - reconnectionDelay: 1000 (1s initial delay) - reconnectionDelayMax: 10000 (10s max backoff) - reconnectionAttempts: Infinity (always retry)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the WebSocket connection drops (transport close, ping timeout, server restart), the socket.io client may not automatically reconnect depending on version/configuration. This causes agents to silently go offline and miss all incoming jobs until manually restarted.
In production, we observed agents losing ~88% of jobs due to unhandled disconnections during network instability.
Fix
Explicitly configure socket.io reconnection options:
reconnection: true— ensure reconnection is enabledreconnectionDelay: 1000— 1s initial retry delayreconnectionDelayMax: 10000— 10s max backoffreconnectionAttempts: Infinity— never stop tryingImpact
Agents will automatically reconnect after transient network issues, preventing silent job loss. This is critical for long-running seller runtimes that need 24/7 uptime.
Testing