This repository was archived by the owner on Nov 25, 2025. It is now read-only.
feat(0.3): make accept fallible#116
Closed
rvolosatovs wants to merge 1 commit intoWebAssembly:mainfrom
Closed
Conversation
`accept` is fallible, however there is currently no way to report the error to the user from the stream. Change the stream element type to `result<tcp-stream, error-code>` to account for that Ref https://www.man7.org/linux/man-pages/man2/accept.2.html Ref https://github.com/bytecodealliance/wasip3-prototyping/blob/7dbc8a9fd6a2348e772a32382c3e29c88cad397e/crates/wasi/src/p3/sockets/host/types/tcp.rs#L195-L199 Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Contributor
Author
|
I guess I'll just go for this option: wasi-sockets/wit-0.3.0-draft/types.wit Lines 272 to 274 in 4728257 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
acceptis fallible, however there is currently no way to report the error to the user from the stream.Change the stream element type to
result<tcp-stream, error-code>to account for thatRef https://www.man7.org/linux/man-pages/man2/accept.2.html
Ref https://github.com/bytecodealliance/wasip3-prototyping/blob/7dbc8a9fd6a2348e772a32382c3e29c88cad397e/crates/wasi/src/p3/sockets/host/types/tcp.rs#L195-L199
Ref bytecodealliance/wasip3-prototyping#1