Fix import to support Tomcat and Jetty newest versions.#55
Open
h3xstream wants to merge 1 commit intoWebGoat:masterfrom
Open
Fix import to support Tomcat and Jetty newest versions.#55h3xstream wants to merge 1 commit intoWebGoat:masterfrom
h3xstream wants to merge 1 commit intoWebGoat:masterfrom
Conversation
Contributor
|
How does this affect the dependencies on the embedded container? @nbaars What happened to these jsp files in the new WebGoat. |
Author
|
I stumble upon this incompatibility because I was precompiling the jsp with Jetty JSPC (latest version). I assume this would be the same error when visiting the page with the latest container. I do not suspect that removing the semicolon would create any backward compatibility problem. I can see imports that just like this one : https://github.com/WebGoat/WebGoat-Legacy/blob/master/src/main/webapp/reportBug.jsp#L3 I am not sure to understand the question about the new WebGoat .. Are you talking about WebGoat 7? |
Author
|
@mayhew64 Ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://discuss.zendesk.com/hc/en-us/articles/206211847-Upgrade-to-Tomcat-7-0-57-and-8-0-15-or-Later-may-Cause-JSP-Compilation-Error-HTTP-Status-500-Unable-to-compile-class-for-JSP-on-JSP-Page